feat(obs): introduce gpc.client.repo and gcp.client.artifact span attributes#4111
Closed
diegomarquezp wants to merge 87 commits intomainfrom
Closed
feat(obs): introduce gpc.client.repo and gcp.client.artifact span attributes#4111diegomarquezp wants to merge 87 commits intomainfrom
diegomarquezp wants to merge 87 commits intomainfrom
Conversation
This reverts commit b7b9e31.
- Rename SpanHandle to GaxSpan - Simplify adding op and attempt attributes - Use HashMap instead of ConcurrentHashMap - Remove error handling (for now)
…icTracer.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…om/googleapis/sdk-platform-java into observability/initial-tracing-impl
…googleapis/sdk-platform-java into observability/tracing-attr/repo
diegomarquezp
changed the title
|
|
Contributor
Author
|
Closing in favor of approach described in #4118 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new generated class
GapicPropertiesacross all client GAPICs to store metadata such as the source repository and artifact name.Changes
1. Gapic Generator (
gapic-generator-java)GapicPropertiesClassComposerto generate a singleGapicProperties.javaper library.ParserandPluginArgumentParserto acceptrepositoryandartifact(viaGapicContext).AbstractServiceStubSettingsClassComposerto integrateGapicPropertiesinto the generated stub settings. Each service'sStubSettingswill have agetGapicPropertiess()method that will returnnew GapicProperties(). This is meant for later extension of GapicProperties in case there are service-specific methods.2. GAX (
gax-java)AbstractGapicPropertiesto provide a standard interface for library metadata.StubSettingsandClientContextto hold and propagateGapicProperties.3. Library Generation Scripts
generate_library.shandutilities.pyto extract repository and artifact information from the configuration and pass them to the generator.Manual test
The attributes are being recorded correctly.
