This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Open
Conversation
Contributor
|
My usual thought here is if it's worth adding to observe.js, vs another repository/file? Certainly not opposed to having it here, if it's going to be widely used. There was a push at one point to drive observe.js to a small size, because folks are generally very sensitive about code size. Another option is to start building up another .js file with utilities, and folks can include that in their page/build if desired. (A similar question arose around a "DeepObjectObserver" recently.) |
Contributor
|
My two cents are that this type of functionality is best served via additional repositories which we link to or in a utils file/directory. That way we avoid the size of the shim growing with what some may consider optionally useful helpers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new type of observer constructs observers for each element of the array, even as the elements of the array changes. It reports changes to the array itself similar to ArrayObserver, and reports changes to the elements as sent by the user-created element observer type.