Maybe use io.grpc.Uri for target parsing in ManagedChannelRegistry #12608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Jan 16, 2026
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Ugh. That's annoying for so small a usage. But it all makes sense.
FWIW, we've been moving things to testFixtures over time, since those are never shipped to users (and users have used some of our internal test utilities). So api/src/testFixtures would have been a bit better, but it's not that big of a deal and can be changed later.
Member
Author
OK moved it to api/src/testFixtures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not squash.