Added Kerstin Carson to website project pg#8527
Added Kerstin Carson to website project pg#8527t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 7 PM 02/25/26 |
Mykola-Lopushenko
left a comment
There was a problem hiding this comment.
Hi @mocodesss,
Great job!
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- In the issue, you've correctly assigned yourself.
- The CodeQL alerts have been correctly checked off.
- In the issue, you've correctly set the project status.
- In the issue, action items have correctly been checked off.
- Visuals before/after changes are applied.
I approve your first issue.
myronchen-git
left a comment
There was a problem hiding this comment.
Thank you for completing this good first issue. Other than the one thing that needs to be changed, everything else is good. Good job.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- The what in the pull request description is adequately described.
- The CodeQL alerts have been correctly checked off.
- Code changes have been correctly made.
- In the originating issue, you've correctly assigned yourself.
- In the originating issue, you've correctly set the project status.
- In the originating issue, action items have correctly been checked off.
- In the originating issue, you've given your availability and ETA.
Changes that need to be made
- The why description in your pull request could be better. What you currently have reiterates the what. The why would need to explain why Kerstin needs to be added.
On a side note, in your originating issue 8440, you do not need to put before and after screenshots there. It is only needed in the pull request.
|
By the way, you shouldn't assign anybody as assignee for pull requests. I've went ahead and unassigned you already. |
|
Thank you @myronchen-git! That makes a lot of sense, I updated the "Why" to be more descriptive and looking at the big picture here. And, noted on no assignees, thank you for removing that. |
myronchen-git
left a comment
There was a problem hiding this comment.
Thank you for making the changes. That's all from me. Good job.
Fixes #8440
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied