feat: add image expand/review dialog to rating and yes/no voting modes#390
Open
Oyelakin-Mercy wants to merge 2 commits intohatnote:masterfrom
Open
feat: add image expand/review dialog to rating and yes/no voting modes#390Oyelakin-Mercy wants to merge 2 commits intohatnote:masterfrom
Oyelakin-Mercy wants to merge 2 commits intohatnote:masterfrom
Conversation
# Conflicts: # frontend/src/components/Vote/VoteEdit.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this issue #321 and saw that the expand icon, which shows the image information, including the links, was not in the yes/no or rating rounds. But it was on the ranking round. I think it would be a great addition to have it in all rounds, just like the juror wants it to. I have added the expand icon and image review dialog to the rating and yes/no voting rounds.
How to test: