Skip to content

feat(auth): add err handle when input bad format email#3

Open
avtara wants to merge 5 commits intodevfrom
alpha
Open

feat(auth): add err handle when input bad format email#3
avtara wants to merge 5 commits intodevfrom
alpha

Conversation

@avtara
Copy link
Copy Markdown
Collaborator

@avtara avtara commented May 31, 2020

No description provided.

@avtara avtara added the enhancement New feature or request label May 31, 2020
@avtara avtara requested a review from blinfoldking May 31, 2020 13:06
Comment thread src/auth/auth.entity.ts Outdated
Comment thread src/auth/auth.entity.ts Outdated
Comment thread src/auth/auth.entity.ts Outdated
Comment thread src/auth/auth.entity.ts

type RegisterResult = {
id?: string,
token?: string,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kenapa optional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soalnya kalo error ga ngembaliin id sama token jadinya di optionalin, gitu

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harus nya gausah kalo error promise nya aja yang di throw error

@avtara avtara requested a review from blinfoldking June 1, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants