chore: regenerate client from updated OpenAPI spec#14
Conversation
|
Automated review unavailable (Claude step failed). Please review manually. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| @validate_call | ||
| def check_connection_health_handler( | ||
| def check_connection_health( |
There was a problem hiding this comment.
All API methods have been renamed by dropping the _handler suffix (e.g. check_connection_health_handler → check_connection_health). This is a breaking change for any callers using the old names. Same applies to every other API class in this PR (datasets_api.py, workspaces_api.py, etc.).
Before merging, this needs either a semver major/minor bump (depending on the project's versioning policy) or, if still pre-1.0, a clear CHANGELOG / migration note documenting the rename.
| from hotdata.models.boolean_profile_detail import BooleanProfileDetail | ||
| from hotdata.models.categorical_profile_detail import CategoricalProfileDetail | ||
| from hotdata.models.category_value_info import CategoryValueInfo | ||
| from hotdata.models.column_definition import ColumnDefinition |
There was a problem hiding this comment.
Five public types are removed in this PR:
ColumnDefinition(here)CreateWorkspace201Response→CreateWorkspaceResponseDatasetSourceOneOf/DatasetSourceOneOf1→InlineDatasetSource/UploadDatasetSourceListWorkspaces200Response→ListWorkspacesResponse
Any downstream code importing these by name will break at runtime. Same concern as the API method renames — needs a version bump and migration notes.
There was a problem hiding this comment.
Review
Issues
[P1] Breaking API changes with no version bump or migration notes
This regeneration introduces two categories of breaking changes with no accompanying version increment or changelog:
-
All API method names changed — every
*_handlersuffix was dropped across all API classes (connections_api.py,datasets_api.py,workspaces_api.py, etc.). See inline comment onhotdata/api/connections_api.py:47. -
Five public model types removed —
ColumnDefinition,CreateWorkspace201Response,DatasetSourceOneOf,DatasetSourceOneOf1,ListWorkspaces200Response. Existing code importing these will fail at import time. See inline comment onhotdata/models/__init__.py:19.
Action Required
Before this can merge:
- Bump the package version in
setup.py(major bump if semver ≥ 1.0, otherwise at minimum a minor bump). - Add a CHANGELOG entry or migration guide documenting (a) the method renames and (b) the removed/renamed model types, so consumers know how to update their code.
1 participant
Auto-generated from updated HotData OpenAPI spec.