Skip to content

Improve error handling#12

Open
darshankabariya wants to merge 9 commits intohoytech:masterfrom
logos-messaging:improve_error_handling
Open

Improve error handling#12
darshankabariya wants to merge 9 commits intohoytech:masterfrom
logos-messaging:improve_error_handling

Conversation

@darshankabariya
Copy link
Copy Markdown
Contributor

Summary

Enhances error handling in Negentropy C++ wrapper and Nim bindings for Waku Sync. Replaces boolean-based error reporting with system-generated error messages.

Key Changes

  • Added thread-local lastError string and get_last_error() function in C++.
  • Updated C++ functions to set specific error messages.
  • Enhanced Nim bindings to use a new error reporting mechanism.

@hoytech
Copy link
Copy Markdown
Owner

hoytech commented Oct 8, 2024

Hi! Did you see my comment here? #9 (comment)

In short, I moved the C language wrapper stuff into a new directory c/ to keep a clean separation between the C++ and the bindings. So, this PR will not merge cleanly (but it's probably just a matter of using the new directory structure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants