Skip to content

Conversation

@suddendust
Copy link
Contributor

Description

This PR fixes a bug in FlatPostgresCollection#createOrReplace in which for replace cases, it overwrites the unspecified fields with their default values.

Testing

Added integration tests to check for this.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.68%. Comparing base (d112d17) to head (1ea7237).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #276      +/-   ##
============================================
+ Coverage     80.65%   80.68%   +0.03%     
  Complexity     1396     1396              
============================================
  Files           240      240              
  Lines          6871     6882      +11     
  Branches        638      638              
============================================
+ Hits           5542     5553      +11     
  Misses          914      914              
  Partials        415      415              
Flag Coverage Δ
integration 80.68% <100.00%> (+0.03%) ⬆️
unit 53.18% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

*
* <pre>{@code
* INSERT INTO table (col1, col2, pk_col)
* INSERT INTO table (col1, col2,, col3, pk_col)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
* INSERT INTO table (col1, col2,, col3, pk_col)
* INSERT INTO table (col1, col2, col3, pk_col)

@suddendust suddendust changed the title [FlatPostgresCollection] Fix createOrReplace Behaviour [Bugfix] Fix createOrReplace Behaviour Feb 10, 2026
@suddendust suddendust merged commit 65909a2 into hypertrace:main Feb 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants