Ibx 11236 use ds btn component by tischsoic · Pull Request #1838 · ibexa/admin-ui

tischsoic · 2026-02-26T09:58:00Z

🎫 Issue	IBX-XXXXX

Description:

For QA:

Documentation:

Migrate filter buttons and edit translation buttons to use the design system twig:ibexa:button component for consistent styling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Automated migration tool for migrating legacy UI components to design system. Features: - Chunk-based processing with OpenCode CLI integration - Automatic branch creation for isolated migrations - Retry logic with automatic rollback on failure - Frontend validation (yarn test) integration - Progress tracking, logging, and error reporting - Component-agnostic architecture (supports buttons, badges, etc.) Components: - migrate-buttons.sh: Bash orchestrator (789 LOC) - MIGRATION_RULES.md: Button migration guide with variant mappings - BUTTON_MIGRATION_PLAN.txt: Chunk definitions and file inventory - .claude/: Skills and settings for AI-assisted migrations - .button-migration/: Working directory for logs and state Usage: ./migrate-buttons.sh --chunk CHUNK_03 ./migrate-buttons.sh --start-from 5 ./migrate-buttons.sh --dry-run See: MIGRATION_RULES.md, BUTTON_MIGRATION_PLAN.txt

- Move BUTTON_MIGRATION_PLAN.txt → migrations/button/ - Move MIGRATION_RULES.md → migrations/button/ - Move prompts/ → migrations/button/prompts/ - Add .migration-state/ for runtime tracking (gitignored) - Prepare structure for multi-component migrations (badges, etc.)

Rewrite of bash script with enhanced features: Features: - Component-agnostic architecture (buttons, badges, alerts, etc.) - Automatic branch isolation (migrate/buttons, migrate/badges) - Type-safe with comprehensive TypeScript types - Modular library structure (git, opencode, validation, etc.) - Skip-on-failure with progress tracking - Real-time output streaming - Colored logging with progress indicators Structure: - scripts/migrate-component.ts - Main orchestrator - scripts/lib/ - Modular utilities (9 modules) - scripts/config/ - Component configurations - scripts/types.ts - TypeScript definitions Usage: cd scripts/ npm run migrate:button -- --chunk CHUNK_03 npm run migrate:badge -- --chunk CHUNK_01 Branch Strategy: - Migrations run on isolated branches (migrate/*) - Never merged back to base branch - Clean separation of tool commits vs migration commits Removed: - migrate-buttons.sh (789 LOC bash script) - .button-migration/ working directory See: scripts/README.md

…stem-twig - Replace 1 button-styled link with <twig:ibexa:link variant="button"> - Map to primary button type - Preserve ibexa-btn--login class - Preserve translation strings and href path Refs: BUTTON_MIGRATION_PLAN.md

- Replace 1 button-styled link with <twig:ibexa:link variant="button"> - Map ghost style to tertiary type with small size - Add edit icon (icon="edit", icon_size="small-medium") - Preserve conditional rendering logic Refs: BUTTON_MIGRATION_PLAN.md

…esign-system-twig - Replace 2 button-styled links with <twig:ibexa:link variant="button"> - Back button: tertiary with back icon - Sign in button: primary type - Preserve custom classes and translations Refs: BUTTON_MIGRATION_PLAN.md

…twig - Replace 1 show more/less toggle button with <twig:ibexa:button> - Map ghost style to tertiary type with small size - Add arrow-caret-down icon - Preserve custom classes and complex nested label structure Refs: BUTTON_MIGRATION_PLAN.md

…m-twig - Replace 1 upload file button with <twig:ibexa:button> - Map to secondary button type - Preserve conditional disabled state - Preserve custom data-source classes and nested label Refs: BUTTON_MIGRATION_PLAN.md

- Remove double curly braces from :disabled attribute - Twig component attributes with colon prefix should not have {{ }} Refs: BUTTON_MIGRATION_PLAN.md

- Replace legacy button-styled link with <twig:ibexa:link variant="button"> - Replace legacy button with <twig:ibexa:button> - Migrate continue link (primary type) - Migrate cancel button (secondary type, modal dismiss) - Preserve modal dismiss functionality via attr parameter

- Replace legacy ghost button link with <twig:ibexa:link variant="button"> - Migrate download button for binary file field (ghost type, download icon) - Preserve download attribute and ml-4 spacing class

Updates the shared admin Symfony form theme to default button and submit widgets to DS button classes, while preserving Symfony-generated attributes and behavior. Also updates the content create submit override to use DS classes so the extra actions footer stays visually consistent.

sonarqubecloud · 2026-03-24T11:26:10Z

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarQube Cloud

tischsoic self-assigned this Feb 26, 2026

barbaragr mentioned this pull request Feb 26, 2026

Run regression for IBX-11332 ibexa/commerce#1700

Draft

github-actions bot assigned ciastektk, dew326, mikadamczyk and ViniTou and unassigned mikadamczyk, ciastektk and ViniTou Feb 26, 2026

tischsoic force-pushed the IBX-11236-use-ds-btn-component branch from 30c24df to 5c13474 Compare March 2, 2026 07:58

barbaragr mentioned this pull request Mar 2, 2026

Run regression for IBX-11332 ibexa/oss#264

Draft

tischsoic force-pushed the IBX-11236-use-ds-btn-component branch 2 times, most recently from 69e583a to 2ccfc8f Compare March 8, 2026 22:07

tischsoic force-pushed the IBX-11236-use-ds-btn-component branch 3 times, most recently from 0b21d42 to 7f4c061 Compare March 23, 2026 12:01

tischsoic and others added 14 commits March 24, 2026 10:39

design-system-twig composer

cf50f45

draft list delete button

35f4da4

Replace buttons with design system button component in search view

67128a5

Migrate filter buttons and edit translation buttons to use the design system twig:ibexa:button component for consistent styling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

fix: Correct Twig syntax error in binary_base.html.twig

892684c

- Remove double curly braces from :disabled attribute - Twig component attributes with colon prefix should not have {{ }} Refs: BUTTON_MIGRATION_PLAN.md

Migrate button in ui/field_type/preview/content_fields.html.twig

2a6cb4a

- Replace legacy ghost button link with <twig:ibexa:link variant="button"> - Migrate download button for binary file field (ghost type, download icon) - Preserve download attribute and ml-4 spacing class

tischsoic added 27 commits March 24, 2026 10:39

fix: use DS classes in wildcard create modal button

0c2d2e2

fix: use DS classes in empty trash confirm button

6e29b9b

fix: use DS classes in language delete modal button

0beb7a3

fix: use DS classes in user delete modal button

468d813

fix: use DS classes in custom URL modal button

0471fd6

fix: use DS classes in section delete modal button

ead0f89

fix: use DS classes in content add translation button

d1ce3a7

fix: use DS classes in trash restore buttons

7927ec7

fix: use DS classes in location trash modal button

414cc24

fix: use DS classes in user invitation submit button

d06fa64

fix: provide DS icon assets context in UDW

043dfa9

fix: provide DS icon assets context in sub-items

5744a62

fix: use DS classes in collapse all button

7e728a2

fix: use DS classes in adaptive filters toggler

ab7b0e6

fix: use DS classes in bookmarks bulk action button

eacb9ca

fix: use DS classes in tag view select button

ed451c2

fix: use DS classes in section assigned content button

aea99be

fix: use DS classes in location swap button

0ce0773

fix: use DS classes in context menu buttons

112b376

fix: use DS classes in sidebar base buttons

8fa98c7

fix: use DS classes in right sidebar buttons

6d4be37

fix: use DS classes in action list buttons

59a5bb1

fix: support DS button markup in context menu script

ab2c3f5

fix: align DS modal close buttons

b3b7ec2

fix: hide adaptive filter fake DS toggler buttons

d0257d8

fix: restore DS styling in account auth forms

7bbd081

tischsoic force-pushed the IBX-11236-use-ds-btn-component branch from 7f4c061 to 7bbd081 Compare March 24, 2026 09:39

fix: align DS button icon sizing

a3d4193

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ibx 11236 use ds btn component#1838

Ibx 11236 use ds btn component#1838
tischsoic wants to merge 218 commits intomainfrom
IBX-11236-use-ds-btn-component

tischsoic commented Feb 26, 2026

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

tischsoic commented Feb 26, 2026

Description:

For QA:

Documentation:

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants