Draft
Conversation
Agent-Logs-Url: https://github.com/igraph/rigraph/sessions/6623329c-8d18-4af2-ad47-a28ac5c5fbd8 Co-authored-by: schochastics <17147355+schochastics@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove TODO comment from make.R
perf: speed up Mar 27, 2026
.apply_modifiers() in make.R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
## TODO: speed this upcomments in.apply_modifiers()by implementing the actual speedups.Changes
without_attr: Replace three O(N) loops (get names → delete one-by-one) with three direct bulk assignments tosetNames(list(), character())— O(1) regardless of attribute count.with_vertex_/with_edge_: Replace per-attributeset_vertex_attr/set_edge_attrcalls (each doing a full C-level get+modify+set cycle) with a single get → in-memory loop with scalar recycling and length validation → single set. Reduces from N get+set pairs to 1 get + 1 set.with_graph_: Replace per-attribute loop withmodifyList()+graph.attributes<-for a single get+set cycle.with_vertex_()andwith_edge_().🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.