fix: use dynamic anchor id from network prop in AddNetworkButton#607
Open
amathxbt wants to merge 1 commit intoinkonchain:mainfrom
Open
fix: use dynamic anchor id from network prop in AddNetworkButton#607amathxbt wants to merge 1 commit intoinkonchain:mainfrom
amathxbt wants to merge 1 commit intoinkonchain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
AddNetworkButtonhardcodesid="mainnet"andhref="#mainnet"on the section anchor regardless of whichnetworkprop is passed:When this component is rendered for both mainnet and sepolia on the same page, two elements share
id="mainnet", which:idattributes)#mainnetalways jumps to the first matching element, making the second network section unreachable via URL hashidmust be unique per page)Fix
Derive the
idandhrefdynamically from thenetworkprop:Impact
Anywhere this component is rendered for multiple networks on one page, anchor navigation for all networks except the first is silently broken.