Open
Conversation
mvitz
force-pushed
the
130-fix-w3c-validator-errors
branch
2 times, most recently
from
364c9b7 to
340c6bc
Compare
mvitz
force-pushed
the
130-fix-w3c-validator-errors
branch
from
340c6bc to
00afd62
Compare
mvitz
force-pushed
the
130-fix-w3c-validator-errors
branch
from
00afd62 to
27264cf
Compare
mvitz
force-pushed
the
130-fix-w3c-validator-errors
branch
from
27264cf to
bd8bf42
Compare
Specifying the charset prevents the browser from guessing the charset to use. Relates to innoq#130.
Instead of a header with role navigation now the HTML5 element nav is used. Relates to innoq#130.
Removes warnings from w3c validator that label and input are not valid inside an a element. Because preferences aren't links anyway this increases semantic as well. Relates to innoq#130.
By default hiccup generates an id for every form field. In our case (more than one form with method DELETE on the same page) this leads to non unique ids which leads to w3c validation errors. Relates to innoq#130. Workaround for weavejester/hiccup#109.
Only inline elements may be contained whithin inline elements. Because form is not an inline element this leads to w3c validation errors. Relates to innoq#130.
mvitz
force-pushed
the
130-fix-w3c-validator-errors
branch
from
bd8bf42 to
d477a31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all w3c validation errors/warnings as described in #130.