feat: improve content type sys field type#162
Open
marcogrcr wants to merge 1 commit intointercom:masterfrom
Open
feat: improve content type sys field type#162marcogrcr wants to merge 1 commit intointercom:masterfrom
marcogrcr wants to merge 1 commit intointercom:masterfrom
Conversation
WHAT? Improve the `sys` field type on content types so that they re-use the `Sys` type from the `contentful` module. WHY? The `Sys` type can change over time. For example, the current type is missing the `revision`, `space` and `environment` fields. By re-using there's no need to manually keep these types in sync. HOW? `yarn test`
Author
|
As a temporary workaround. Users can use this script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT?
Improve the
sysfield type on content types so that they re-use theSystype from thecontentfulmodule.WHY?
The
Systype can change over time. For example, the current type is missing therevision,spaceandenvironmentfields. By re-using there's no need to manually keep these types in sync.HOW?
yarn test