Add ability to set the Intercom API region by injecting the base URI#356
Open
eexit wants to merge 2 commits intointercom:masterfrom
Open
Add ability to set the Intercom API region by injecting the base URI#356eexit wants to merge 2 commits intointercom:masterfrom
eexit wants to merge 2 commits intointercom:masterfrom
Conversation
Author
|
Hi @dannyfallon, Could you check why the CI is failing? It looks like the auth token is gone or expired.. Thanks! |
Contributor
|
Howdy @eexit, thanks for the ping. I've checked over the GitHub settings in our org and CircleCI is still there. I've also managed to make a new branch and Circle tested it for me. I can see other folks had their PRs work as recently as July and to my knowledge there's been no changes. Can I ask if this is an issue with your own CircleCI setup? Can you log out of Circle and back in using GitHub then re-push your branch to see if that fixes it? If it doesn't I'll reach out to Circle to see what's up. |
Author
|
@dannyfallon Awesome, thanks! CI is green now 🎉 |
colmdoyle
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Out integration is based in another region than the US.
https://developers.intercom.com/building-apps/docs/rest-apis#available-endpoints
How?
Adding an optional parameter to the client constructor, defaulted with the US region to avoid any BC.