make IntercomClient methods protected#360
Open
cosmastech wants to merge 2 commits intointercom:masterfrom
Open
make IntercomClient methods protected#360cosmastech wants to merge 2 commits intointercom:masterfrom
cosmastech wants to merge 2 commits intointercom:masterfrom
Conversation
ivastly
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
I think private visibility of the IntercomClient methods is a hinderance.
In a project I am working on, I need to decorate the
handleResponse()method so that it checks for errors returned in the response (and possibly updates cache), but right now, the only way to do this is to duplicate code from base IntercomClient class (and not just a little bit, pretty much all of it).How?
sets all private methods to protected visibility.