Skip to content

[_] Hide terms link in mobile view#1934

Merged
CandelR merged 1 commit intomasterfrom
feat/hide-tc-in-mobile-view
Apr 17, 2026
Merged

[_] Hide terms link in mobile view#1934
CandelR merged 1 commit intomasterfrom
feat/hide-tc-in-mobile-view

Conversation

@CandelR
Copy link
Copy Markdown
Collaborator

@CandelR CandelR commented Apr 17, 2026

Description

  • Hide terms link on mobile view to comply with Google Play requirements

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

  • Check that only on mobile views cannot acces to TC

Additional Notes

@CandelR CandelR requested a review from xabg2 April 17, 2026 09:30
@CandelR CandelR self-assigned this Apr 17, 2026
@CandelR CandelR requested a review from larryrider as a code owner April 17, 2026 09:30
@CandelR CandelR added the enhancement New feature or request label Apr 17, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd8f106
Status: ✅  Deploy successful!
Preview URL: https://00eee1dc.drive-web.pages.dev
Branch Preview URL: https://feat-hide-tc-in-mobile-view.drive-web.pages.dev

View logs

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@xabg2 xabg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be better to extract all the repeated URLs to a constant instead. Then, if we need two update it, we only need to update 1 link instead of 10

@CandelR CandelR merged commit 75bea13 into master Apr 17, 2026
10 of 11 checks passed
@CandelR CandelR deleted the feat/hide-tc-in-mobile-view branch April 17, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants