Skip to content

Enable selection of range spacing or azimuth time interval in the STATIC runconfig#178

Open
gshiroma wants to merge 26 commits intoisce-framework:developfrom
gshiroma:improve_static_layers_workflow_expose_az_rg_spacing
Open

Enable selection of range spacing or azimuth time interval in the STATIC runconfig#178
gshiroma wants to merge 26 commits intoisce-framework:developfrom
gshiroma:improve_static_layers_workflow_expose_az_rg_spacing

Conversation

@gshiroma
Copy link
Copy Markdown
Contributor

This PR addresses the 3rd item in #158. It exposes an option in the STATIC runconfig to select either the range spacing or the azimuth time interval. If one of these values is not provided, the STATIC workflow will infer it using the radar parameters and the geogrid.

gshiroma and others added 22 commits July 3, 2025 11:30
Copy link
Copy Markdown
Contributor

@hfattahi hfattahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread share/nisar/defaults/static.yaml Outdated
az_spacing = radar_grid_spacing_params["az_spacing"]
rg_spacing = radar_grid_spacing_params["rg_spacing"]
pts_per_side = radar_grid_spacing_params["pts_per_side"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some sanity rg_spacing and az spacing is not zero will be nice.

@gshiroma gshiroma requested a review from Tyler-g-hudson April 22, 2026 23:45
Co-authored-by: Heresh Fattahi <hersh.fattahi@gmail.com>
Copy link
Copy Markdown
Contributor

@Tyler-g-hudson Tyler-g-hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants