Skip to content

Add Camera Reader#59

Merged
SBlokhuizen merged 22 commits intodevelopfrom
feature/camera-reader
Apr 15, 2026
Merged

Add Camera Reader#59
SBlokhuizen merged 22 commits intodevelopfrom
feature/camera-reader

Conversation

@SBlokhuizen
Copy link
Copy Markdown
Collaborator

This adds a new reader, the Camera Reader, to visualize the camera sightlines of camera_ir and camera_visible. This includes the option to match the ParaView camera with a selected camera, and get a point of view visualization of what the camera is seeing.

@SBlokhuizen SBlokhuizen self-assigned this Apr 7, 2026
@SBlokhuizen SBlokhuizen requested a review from Yannicked April 7, 2026 09:41
@paulotex
Copy link
Copy Markdown
Contributor

paulotex commented Apr 7, 2026

tested and working for me.

One request though:
When selecting the camera to snap the view, is it possible to mark the frustum in any way? Perhaps change the line color, or increase the thickness? For example, change the color to one of these:

image

Comment thread imas_paraview/plugins/camera.py Outdated
@SBlokhuizen
Copy link
Copy Markdown
Collaborator Author

tested and working for me.

One request though: When selecting the camera to snap the view, is it possible to mark the frustum in any way? Perhaps change the line color, or increase the thickness? For example, change the color to one of these:
image

Hi @paulotex, I have tried to implement this but I cannot find a nice way to do it. The issue is that the readers just provide the VTK data for ParaView to display, how ParaView renders this (e.g. color / line width) we don't have much a control over from the plugin side.

A workaround I have found is to attach an integer (0 or 1) to the camera data to flag the active selection. You would need to select this ActiveCamera array in the coloring properties though. What do you think of this solution?

Screencast.From.2026-04-09.17-31-12.mp4

@SBlokhuizen SBlokhuizen marked this pull request as ready for review April 9, 2026 15:40
@SBlokhuizen SBlokhuizen requested a review from maarten-ic as a code owner April 9, 2026 15:40
Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments. Please have a look and let me know if you'd like to discuss any.
GH also indicates there's a merge conflict, can you have a look at that as well?

Thanks!

Comment thread docs/source/camera_reader.rst Outdated
Comment thread imas_paraview/plugins/camera.py
Comment thread imas_paraview/plugins/camera.py Outdated
Comment thread imas_paraview/plugins/camera.py Outdated
Comment thread imas_paraview/plugins/camera.py Outdated
Comment thread imas_paraview/plugins/camera.py
Comment thread imas_paraview/plugins/camera.py
Comment thread imas_paraview/plugins/camera.py Outdated
Comment thread imas_paraview/plugins/camera.py
Comment thread imas_paraview/util.py
@SBlokhuizen SBlokhuizen requested a review from maarten-ic April 10, 2026 13:45
Comment thread imas_paraview/plugins/camera.py
@paulotex
Copy link
Copy Markdown
Contributor

A workaround I have found is to attach an integer (0 or 1) to the camera data to flag the active selection. You would need to select this ActiveCamera array in the coloring properties though. What do you think of this solution?

Thanks, this would work. However, it now duplicates some of the functionality of the Multiblock Inspector. So I think we can leave this feature for now and we can point the user to the multiblock inspector, if they need to highlight a camera.

Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. Can you have a look at the Merge conflicts as well?

Thanks!

Comment thread docs/source/plugins/camera_reader.rst Outdated
Comment thread imas_paraview/plugins/camera.py Outdated
@SBlokhuizen SBlokhuizen requested a review from maarten-ic April 14, 2026 08:24
@SBlokhuizen SBlokhuizen merged commit af01569 into develop Apr 15, 2026
9 checks passed
@SBlokhuizen SBlokhuizen deleted the feature/camera-reader branch April 15, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants