Open
Conversation
zoic21
approved these changes
Dec 18, 2024
87c4753 to
5a9aa4b
Compare
39dff1b to
e73f03b
Compare
d7c41c9 to
327ebc3
Compare
327ebc3 to
dabc655
Compare
dabc655 to
ec85c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Le healtchckeck dans le Dockerfile permet nativement à Docker de savoir la santé du container, c'est pratique pour le monitoring, on peut directement voir dans un simple
docker run ...s'il a fini de démarrer ou pas... Et ça n'empêche pas de surcharger ce healtchcheck dans docker-compose ou ailleurs, on peut le voir comme un healthcheck par défaut.Et on l'utilise dans le workflow github au lieu du
sleep45pour attendre la fin du démarrage.Suggested changelog entry
Related issues/external references
Fixes #
Types of changes
PR checklist