Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new rake task that can be used to update snapshots:
I don't use many snapshot tests but with my CRUD pages generator I do and I expect that I'll also use this approach if/when I get to the CRUD API generator. Maybe I'll find another use for it too - not sure! Oh for bonus points I also left a comment for Future Jon right where the tests usually fail so I can remember how to update them.
In terms of how I update them, I'm only updating the ones that commonly change during the normal course of developing this app. I might change this too if at some point I want to update all of the snapshots and this is not capable of doing that. We shall see!