fix: cleanup useQuoteQuery and remove stray console.log #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo: 'conver' → 'convert' in error message - Remove unused import (keepPreviousData) - Fix code formatting and spacing - Remove console.log from Form.tsx error handler - Add TODO comment for hardcoded excludeRouters
|
Someone is attempting to deploy a commit to the wowcats Team on Vercel. A member of the Team first needs to authorize it. |
happy-edge
pushed a commit
to happy-edge/plugin
that referenced
this pull request
Feb 6, 2026
Previously, when excludeDexes was specified, the plugin would always add a hardcoded list of excludeRouters. This was undocumented and couldn't be overridden. Changes: - Add excludeRouters to FormProps interface with documentation - Only apply default excludeRouters if user doesn't specify their own - Extract default routers to named constant for clarity - Fix typo and remove unused import (from PR jup-ag#217) Users can now: 1. Use excludeDexes alone (gets default router exclusions) 2. Use excludeRouters alone (explicit control) 3. Use both for full control 4. Pass empty excludeRouters=[] to opt out of default behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up minor issues in the codebase:
Changes
'conver'→'convert'in superstruct error messagekeepPreviousDatawas imported but never usedconsole.log('Swap error', error)from Form.tsxexcludeRoutersarray for future considerationFiles Changed
src/queries/useQuoteQuery.tssrc/components/Form.tsxTesting