Add expandable KaitaiStream backed by List<Byte> for serialization#41
Open
pfroud wants to merge 1 commit intokaitai-io:serializationfrom
Open
Add expandable KaitaiStream backed by List<Byte> for serialization#41pfroud wants to merge 1 commit intokaitai-io:serializationfrom
KaitaiStream backed by List<Byte> for serialization#41pfroud wants to merge 1 commit intokaitai-io:serializationfrom
Conversation
|
After some test, At least the bits in bytes function is not OK. I suggest to run more comprehensive tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do serialization, it appears you need to know the total byte length in advance to allocate a
ByteBufferKaitaiStream.From http://doc.kaitai.io/serialization.html:
This pull request is a proposal / starter implementation for a workaround: a
KaitaiStreambacked by aList<Byte>so it can expand.It is for serialization only. For simplicity, all
readmethods are not implemented.This is a temporary solution until Kaitai Struct can compute the length itself. Maybe someone will find it useful.
Example usage:
Or, if you want to provide your own
List: