Add new check categories, fix regex bugs, and expand test coverage #176
Merged
kaplanelad merged 1 commit intomainfrom Mar 29, 2026
Merged
Add new check categories, fix regex bugs, and expand test coverage #176kaplanelad merged 1 commit intomainfrom
kaplanelad merged 1 commit intomainfrom
Conversation
Owner
kaplanelad
commented
Mar 28, 2026
kaplanelad
commented
- Add 5 new check categories: github, npm/yarn/pnpm, flyio, vercel, netlify (30 new rules)
- Add new rules to existing categories: git stash clear, terraform destroy/state rm, fs shred/truncate, docker run --privileged, base halt/poweroff/init, network nft/ip route flush, shell curl|python, database drop index, kubernetes delete --all/apply --force
- Fix 40 regex bugs: 13 false positives (substring matches on --force-if-includes, delete-user-policy, --delete-after, dropdown, heroku \s*, etc.) and 27 false negatives (missing long-form flags, intervening flags, sudo before shell, backtick syntax, etc.)
- Add comprehensive edge case tests across all check files (300+ new test cases)
) - Add 5 new check categories: github, npm/yarn/pnpm, flyio, vercel, netlify (30 new rules) - Add new rules to existing categories: git stash clear, terraform destroy/state rm, fs shred/truncate, docker run --privileged, base halt/poweroff/init, network nft/ip route flush, shell curl|python, database drop index, kubernetes delete --all/apply --force - Fix 40 regex bugs: 13 false positives (substring matches on --force-if-includes, delete-user-policy, --delete-after, dropdown, heroku \s*, etc.) and 27 false negatives (missing long-form flags, intervening flags, sudo before shell, backtick syntax, etc.) - Add comprehensive edge case tests across all check files (300+ new test cases) Co-Authored-By: Elad Kaplan <kaplan.elad@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.