Skip to content

Use lark on Python 3.8+ while keeping lark-parser for older Pythons #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kendonB wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use lark on Python 3.8+ while keeping lark-parser for older Pythons #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e72e4a2
Switch to lark on modern Python versions
kendonB Mar 23, 2026
499c5f8
Update required Kaggle version to 3.1.0
kendonB Mar 23, 2026
55a3dc6
Update CHANGELOG with dependency version bump
kendonB Mar 23, 2026
0f8efe0
Downgrade kaldi-active-grammar to version 3.1.0
kendonB Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ Changed
compiling them directly.
- Change the CommandModule class' optional unload method to invoke top-level
unload functions like the Natlink loader does.
- Bump the supported ``kaldi-active-grammar`` line to 3.2.x so the
``dragonfly[kaldi]`` extra installs the updated dependency set.
- Use ``lark`` on Python 3.8+ and keep ``lark-parser`` for older Python
versions.
- Make the logging output of Dragonfly's CLI commands more sane.
- Make some optimizations to the Natlink engine.
- Rename the engines.backend_sphinx.misc module to config.
Expand Down
2 changes: 1 addition & 1 deletion documentation/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ six
enum34;python_version<'3.4'
sphinx-argparse
sphinx_rtd_theme
lark-parser
lark
2 changes: 1 addition & 1 deletion dragonfly/engines/backend_kaldi/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class KaldiEngine(EngineBase, DelegateTimerManagerInterface):

_name = "kaldi"
# NOTE: Remember to also update setup.py to the same version!
_required_kag_version = "3.2.0"
_required_kag_version = "3.1.0"

#-----------------------------------------------------------------------

Expand Down
7 changes: 5 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ def _try_local_natlink_pyd(self):
"setuptools >= 40.0.0",
"packaging >= 19.0",
"six",
"lark-parser >= 0.8.0",
# Use the renamed package on modern Python versions,
# while keeping compatibility with older versions.
"lark>=1.0.0;python_version>='3.8'",
"lark-parser>=0.8.0;python_version<'3.8'",

# Windows-only dependencies.
"pywin32;platform_system=='Windows'",
Expand Down Expand Up @@ -160,7 +163,7 @@ def _try_local_natlink_pyd(self):
],
"kaldi": [
# NOTE: Remember to also update engine.py to the same version!
"kaldi-active-grammar ~= 3.2.0",
"kaldi-active-grammar ~= 3.1.0",
"sounddevice == 0.3.*",
"webrtcvad-wheels == 2.0.*",
],
Expand Down