Resolve open issues: new algorithms, bug fix, tests#2719
Merged
Conversation
- Fix #256: uncomment strip_url_params tests (bug was Python 3.5 era dict ordering; works correctly in Python 3.7+) - Fix #565: add heap-optimised Dijkstra in O((V+E) log V) using heapq - Fix #908: add Goldbach's conjecture prime decomposition - Fix #829: add binary tree views (left, right, top, bottom) - Fix #651: add sqrt decomposition data structure for O(√n) range queries - Close #383: naming conventions already standardised across the repo Adds 32 new tests (520 total) and README entries for all additions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all actionable open issues by adding new algorithms, fixing a bug, and enabling previously-commented-out tests.
Issues resolved
strip_url_params3bugdijkstra_heapq.py— O((V+E) log V) heap-based implementationgoldbach.py— decompose even numbers into prime pairsbinary_tree_views.py— left, right, top, and bottom viewssqrt_decomposition.py— O(√n) range sum queries with O(1) updatesNew files
algorithms/graph/dijkstra_heapq.pyalgorithms/math/goldbach.pyalgorithms/tree/binary_tree_views.pyalgorithms/data_structures/sqrt_decomposition.pytests/test_issue_fixes.py(32 new tests)Test plan
python -m pytest tests/ -x -q)ruff check .)tests/test_issue_fixes.pystrip_url_paramstests uncommented and passing intests/test_string.py__init__.pyexports updated🤖 Generated with Claude Code