Ignore empty variable names in secretscan#2699
Merged
RebeccaMahany merged 3 commits intokolide:mainfrom Apr 17, 2026
Merged
Conversation
directionless
approved these changes
Apr 17, 2026
Comment on lines
+357
to
+358
| // multiple lines -- in this case, it looks like "\nMY_ENV_VAR1=\nMY_ENV_VAR2=". | ||
| // So first we isolate the actual line we're looking at, then check to see if there's |
Contributor
There was a problem hiding this comment.
You might be able to use the column start field.
Contributor
Author
There was a problem hiding this comment.
I tried that and it worked in practice with the examples I'm looking at (restricting to finding.StartColumn == 2), but I wanted to cover the case in the tab before empty variable test too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2697 -- ignore another common false-positive pattern.
This issue is gitleaks/gitleaks#1828. Since I didn't see a gitleaks workaround at this time, I added another exclusion to our secret processing.