Closed
Conversation
lukellmann
requested changes
Apr 17, 2023
This reverts commit f250352.
lukellmann
reviewed
Apr 17, 2023
lukellmann
requested changes
Apr 18, 2023
Member
lukellmann
left a comment
lukellmann
left a comment
There was a problem hiding this comment.
the versioning plugin seems to be quite complex to configure (see here), should we maybe separate this into two prs? (one getting rid of the gh-pages branch, another one configuring the versioning plugin)
Comment on lines
+16
to
+21
| # 2) Call dokkaHtmlMultiModule for current version | ||
| # - if this is a release build move current docs into docs-cache/$version | ||
| # - otherwise move it into docs-cache/current | ||
| # 3) Build GitHub Pages artifact | ||
| # - Move all folders not named "current" into docs/<folder> | ||
| # - Move current into docs/ |
Member
There was a problem hiding this comment.
i don't get where this is done
Member
Author
There was a problem hiding this comment.
the produceDocs tasks
Member
There was a problem hiding this comment.
is it custom? cause if so, you didn't commit it
Co-authored-by: Lukellmann <47486203+Lukellmann@users.noreply.github.com>
Co-authored-by: Lukellmann <47486203+Lukellmann@users.noreply.github.com>
lukellmann
reviewed
Apr 18, 2023
Member
Author
|
Superseded by #855 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it works for the wiki, let's try this again