Don't use value class Reset with AtomicRef#863
Conversation
|
if we have a breaking change here anyway, do we really need this wrapper around |
|
Probably not |
|
let me see what i can do then |
|
ok, so i kept |
dev.kord.rest.ratelimit.Reset and replace it with plain Instant
|
can you take a look @DRSchlaubi? (can't request an review from you, you are the pr author) |
|
wait a second, i just noticed that we don't even have to change any public api, we can just box/unbox the |
dev.kord.rest.ratelimit.Reset and replace it with plain InstantReset with AtomicRef
lukellmann
left a comment
There was a problem hiding this comment.
simply using the backing Instant should do the job, what do you think @DRSchlaubi?
|
Looks good |
The use of value classes for the
Resetclass has already caused issues implementing #855. However, it was isolated to native platforms. Unfortunately, this behavior will become a compiler error soon, so we need to change it. This can be achieved by simply using the backingInstantinstead ofResetwithAtomicRef.Related Issues
#855
#69
Kotlin/kotlinx-atomicfu#291
KT-61584