Fix #1407: Make 'kpt pkg get' use current directory when '.' is specified by ciaranjohnston · Pull Request #4334 · kptdev/kpt

ciaranjohnston · 2025-12-03T14:13:27Z

When users explicitly pass '.' as the destination directory, kpt pkg get now places files directly in the current directory, matching the behavior of 'git clone' and 'kpt cfg set'.

Changes:

Modified parse.GitParseArgs() to track if destination was explicitly provided
Updated getDest() to use current directory directly when explicitly specified
Modified get.Run() to allow using existing empty directories
Preserved default behavior: when no destination is provided, still creates a subdirectory with the package name

Fixes #1407

netlify · 2025-12-03T14:13:33Z

✅ Deploy Preview for kptdocs ready!

Name	Link
🔨 Latest commit	`9f98870`
🔍 Latest deploy log	https://app.netlify.com/projects/kptdocs/deploys/69b86bd97a763800088955ed
😎 Deploy Preview	https://deploy-preview-4334--kptdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Adjusts kpt pkg get destination resolution so that explicitly specifying the current directory (. / paths that clean to .) places the package contents directly in that directory, aligning behavior with git clone and kpt cfg set.

Changes:

Added an explicitDest signal through argument parsing to distinguish defaulted destinations from user-provided ones.
Updated destination selection logic to treat explicit . as “use current directory”, while keeping the default “create package-name subdir” behavior when dest is omitted.
Updated get.Run() to allow using an existing empty destination directory.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/lib/util/parse/parse.go	Threads `explicitDest` through parsing and adjusts `getDest()` behavior for explicit current-directory destinations.
pkg/lib/util/parse/parse_test.go	Updates parsing tests for the new `GitParseArgs` signature and destination expectations.
commands/pkg/get/cmdget.go	Tracks whether destination was explicitly provided and passes it into parsing.
internal/util/get/get.go	Permits existing empty destination directories (instead of erroring on any existing path).
commands/pkg/get/cmdget_test.go	Updates get command tests to reflect the new explicit-`.` behavior and unchanged default behavior when dest is omitted.
commands/pkg/diff/cmddiff_test.go	Updates diff tests to use the adjusted default `pkg get` destination behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/lib/util/parse/parse.go

pkg/lib/util/parse/parse_test.go

Copilot · 2026-03-02T21:56:57Z

internal/util/get/get.go

+	case err == nil:
+		// Destination exists - check if it's an empty directory
+		if !destInfo.IsDir() {
+			return errors.E(op, errors.Exist, types.UniquePath(c.Destination), fmt.Errorf("destination exists and is not a directory"))
+		}


Allowing an existing empty destination directory introduces a data-loss risk on failure: later errors (e.g., during WriteFile/fetchPackages) call cleanUpDirAndError, which unconditionally os.RemoveAll(c.Destination). If the destination pre-existed (especially when it’s the current directory), this can delete user-owned directories/content. Track whether the destination directory was created by this run and only RemoveAll when it was created; otherwise clean up only the files created by the command (or skip removal).

internal/util/get/get.go

…fied When users explicitly pass '.' as the destination directory, kpt pkg get now places files directly in the current directory, matching the behavior of 'git clone' and 'kpt cfg set'. Changes: - Modified parse.GitParseArgs() to track if destination was explicitly provided - Updated getDest() to use current directory directly when explicitly specified - Modified get.Run() to allow using existing empty directories - Preserved default behavior: when no destination is provided, still creates a subdirectory with the package name Fixes #1407 Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

…tions - Changed getDest() to check cleaned path (v) instead of originalV for '.' comparison - Updated tests to expect current directory when './' or '.' is explicitly passed - Fixed TestCmdMainBranch_execute to not pass './' explicitly - Fixed TestCmd_fail to use non-existent destination directory Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

The test was explicitly passing './' as the destination, which with the new behavior means 'use current directory directly'. Since the test runs in a non-empty workspace directory, this caused a conflict. Removing the explicit destination argument allows the default behavior to create a subdirectory with the package name, which is what the test expects. Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/lib/util/parse/parse.go

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/lib/util/parse/parse.go

internal/util/get/get.go

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

pkg/lib/util/parse/parse.go:263

os.Stat(v) errors other than IsNotExist aren’t handled. If Stat returns (nil, err) for e.g. permission/IO errors, the code will fall through and later call f.IsDir(), which will panic. Handle the non-nil err case explicitly (returning a wrapped/annotated error) before dereferencing f.

	f, err := os.Stat(v)
	if os.IsNotExist(err) {
		parent := filepath.Dir(v)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ciaranjohnston requested review from efiacor, kispaljr, liamfallon and mozesl-nokia as code owners December 3, 2025 14:13

mozesl-nokia approved these changes Dec 10, 2025

View reviewed changes

liamfallon approved these changes Jan 13, 2026

View reviewed changes

ciaranjohnston force-pushed the fix-issue-1407 branch from b8ecd88 to e2529dc Compare January 21, 2026 18:07

Copilot AI review requested due to automatic review settings March 2, 2026 21:53

ciaranjohnston force-pushed the fix-issue-1407 branch from e2529dc to 5616f86 Compare March 2, 2026 21:53

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 2, 2026

Copilot started reviewing on behalf of ciaranjohnston March 2, 2026 21:53 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

ciaranjohnston added 4 commits March 15, 2026 23:09

Fix linting error: rewrite if-else to switch statement

0a02d6b

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

ciaranjohnston force-pushed the fix-issue-1407 branch from 5616f86 to 656576a Compare March 15, 2026 23:12

Copilot AI review requested due to automatic review settings March 15, 2026 23:25

Copilot started reviewing on behalf of ciaranjohnston March 15, 2026 23:25 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

pkg/lib/util/parse/parse.go Show resolved Hide resolved

ciaranjohnston force-pushed the fix-issue-1407 branch from 134d60e to 656576a Compare March 15, 2026 23:32

Updated the test checks to be cleaner and more accurate

be4c4ef

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Copilot AI review requested due to automatic review settings March 15, 2026 23:51

Copilot started reviewing on behalf of ciaranjohnston March 15, 2026 23:52 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

pkg/lib/util/parse/parse.go Outdated Show resolved Hide resolved

pkg/lib/util/parse/parse.go Show resolved Hide resolved

internal/util/get/get.go Show resolved Hide resolved

internal/util/get/get.go Show resolved Hide resolved

ciaranjohnston added 2 commits March 16, 2026 19:56

Removed unused variable

15c07b1

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Skip symlink resolution when directory == .

9f98870

Signed-off-by: Ciaran Johnston <ciaran.johnston@ericsson.com>

Copilot AI review requested due to automatic review settings March 16, 2026 20:45

Copilot started reviewing on behalf of ciaranjohnston March 16, 2026 20:45 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #1407: Make 'kpt pkg get' use current directory when '.' is specified#4334

Fix #1407: Make 'kpt pkg get' use current directory when '.' is specified#4334
ciaranjohnston wants to merge 7 commits intomainfrom
fix-issue-1407

ciaranjohnston commented Dec 3, 2025

Uh oh!

netlify bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ciaranjohnston commented Dec 3, 2025

Uh oh!

netlify bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kptdocs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Dec 3, 2025 •

edited

Loading