Skip to content

Ext 4.2.0 compatibility#31

Open
sunaku wants to merge 4 commits intokveeiv:masterfrom
sunaku:ext-4.2.0
Open

Ext 4.2.0 compatibility#31
sunaku wants to merge 4 commits intokveeiv:masterfrom
sunaku:ext-4.2.0

Conversation

@sunaku
Copy link
Copy Markdown

@sunaku sunaku commented May 3, 2013

These patches make the boxselect plugin work under Ext 4.2.0. 🍰

sunaku added 4 commits April 12, 2013 20:25
The set of filtered records (valueStore) were REPLACED by selected
records in the page currently loaded in the combo box store (store).
Consequently, the user's previous selection was lost when the user made
a new selection from a disjoint page loaded into the combo box store.
This solution was contributed by user "WebProgrammer" on Sencha Forums:
http://www.sencha.com/forum/showthread.php?134751&p=952915
@giovannicandido
Copy link
Copy Markdown

Thank you very much @sunaku you pull request solves at least two problems: #28 #30
I tested in my repository.

@sunaku
Copy link
Copy Markdown
Author

sunaku commented Jun 1, 2013

Awesome! Now if only @kveeiv would merge this pull request. 😅

@BenSwayne
Copy link
Copy Markdown

These patches work for me as well!

However, I did not verify backwards compatibility, but people should be moving towards 4.2 from 4.1 anyhow... lots of significant fixes in extjs overall.

@charlie17
Copy link
Copy Markdown

This looks great, but having one big problem: Will not allow for typing text within the boxselect. If triggerOnClick = true then I can select any of the items that are shown...but if = false then I can't do anything. Almost like the box is disabled altogether, however it worked fine before switching to this pull request version?

@erikaellr
Copy link
Copy Markdown

This is great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants