Implements https://github.com/l3montree-dev/devguard/issues/1879#705
Merged
Implements https://github.com/l3montree-dev/devguard/issues/1879#705
Conversation
Signed-off-by: Sebastian Kawelke <sebastian.kawelke@l3montree.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Implements issue #1879 by hardening externally-configured theme/analytics asset URLs and wiring them into the Next.js root layout so optional theme and analytics resources can be loaded safely from configuration.
Changes:
- Added
parseHttpsUrlhelper to validate absolute HTTPS URLs and ignore invalid inputs. - Restructured theme config into
config.theme(with optional JS integrity) and addedconfig.analytics(script URL, website ID, optional integrity). - Updated
RootLayoutto inject optional theme CSS/JS and analytics scripts based on the new config shape.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config.ts | Adds HTTPS URL parsing/validation and introduces structured theme/analytics config entries. |
| src/app/layout.tsx | Updates layout to conditionally emit theme and analytics <link>/<script> tags using the new config fields (incl. optional SRI). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sebastian Kawelke <sebastian.kawelke@l3montree.com>
refoo0
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.