test: tighten multi-segment vector index coverage and cleanup#6251
Open
test: tighten multi-segment vector index coverage and cleanup#6251
Conversation
Contributor
ReviewClean PR — tests are well-structured and the validation logic is correct. One minor suggestionFragment overlap check could use // current
if covered_fragments.intersection_len(segment.fragment_bitmap()) > 0 {
// slightly more readable
if !covered_fragments.is_disjoint(segment.fragment_bitmap()) {
Everything else looks good
LGTM with the optional nit above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tightens the new multi-segment vector index path added in #6220.
It enforces disjoint fragment coverage when committing a segment set, adds regression coverage that grouped segment coverage matches the union of its source shard coverage, and verifies that remap only touches segments covering affected fragments.
It also adds cleanup coverage for both replaced committed segments and stale uncommitted
_indices/<uuid>artifacts, and documents these contracts in the distributed indexing guide.