fix: return errors for unsupported fixed-size-list child types#6253
Merged
wjones127 merged 1 commit intolance-format:mainfrom Mar 23, 2026
Merged
Conversation
myandpr
force-pushed
the
fix-unsupported-fsl-writer-errors
branch
from
3f62d3b to
9039f83
Compare
Contributor
Author
|
Hey @westonpace , this should address #5654 by returning errors for unsupported FixedSizeList child combinations instead of panicking. Would appreciate your feedback when you have a chance. Thanks! |
wjones127
approved these changes
Mar 23, 2026
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
This looks reasonable to me!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@wjones127 Thanks for the review — appreciate it!🙌 |
westonpace
pushed a commit
that referenced
this pull request
Mar 24, 2026
## Summary - reject unsupported `FixedSizeList` child combinations during schema/type conversion - return schema errors instead of letting these cases reach later panic paths - replace the old panic-based tests with a small matrix of unsupported `FixedSizeList` child cases ## Implementation This keeps the fix at the schema/type conversion boundary instead of deeper in the writer stack. Unsupported `FixedSizeList` child types are now rejected while converting Arrow `DataType` into Lance `LogicalType`. Supported paths remain unchanged, including primitive nested FSL and the existing `FixedSizeList<Struct>` version gating. ## Testing - cargo test -p lance-encoding unsupported_fsl_child_types -- --nocapture - cargo test -p lance-encoding test_fixed_size_list_struct_requires_v2_2 -- --nocapture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FixedSizeListchild combinations during schema/type conversionFixedSizeListchild casesImplementation
This keeps the fix at the schema/type conversion boundary instead of deeper in the writer stack.
Unsupported
FixedSizeListchild types are now rejected while converting ArrowDataTypeinto LanceLogicalType. Supported paths remain unchanged, including primitive nested FSL and the existingFixedSizeList<Struct>version gating.Testing