Skip to content

Increase severity of uses 'sorry'. Fixes #276 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tautastic wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Increase severity of uses 'sorry'. Fixes #276 #305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4014f2
Increase severity of `uses 'sorry'`. Fixes #276
tautastic Feb 26, 2025
2931bec
Merge branch 'leanprover-community:main' into fix-276
tautastic Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/GameServer/RpcHandlers.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,11 @@ def getProofState (_ : Lsp.PlainGoalParams) : RequestM (RequestTask (Option Proo
-- Answer: The last snap only copied the diags from the end of this snap
let mut diag : Array InteractiveDiagnostic := snap.interactiveDiags.toArray

-- Increase the severity of `uses 'sorry'` warnings
diag := diag.map (fun d => if d.toDiagnostic.message == "declaration uses 'sorry'"
then { d with severity? := some Lsp.DiagnosticSeverity.error }
else d)

-- Level is completed if there are no errors or warnings
let completedWithWarnings : Bool := ¬ diag.any (·.severity? == some .error)
let completed : Bool := completedWithWarnings ∧ ¬ diag.any (·.severity? == some .warning)
Expand Down