plugin for MR #845
Open
plugin for MR #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmajali
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
yec-akamai
requested review from
a team,
Copilot,
jriddle-linode,
vshanthe and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yec-akamai
reviewed
Jan 26, 2026
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
The command looks not quite right in regards to the url call. Can you make changes according to the comments?
| from linodecli.help_formatter import SortingHelpFormatter | ||
| from linodecli.helpers import register_debug_arg | ||
|
|
||
| PLUGIN_BASE = "linode-cli get_metrics" |
Contributor
There was a problem hiding this comment.
In my opinion the plugin base should be more generic, and allow the commend to be a specific operation, i.e.
PLUGIN_BASE = "linode-cli monitor-api"
and implement a command get-metrics
| PLUGIN_BASE = "linode-cli get_metrics" | ||
|
|
||
| # API Configuration | ||
| API_BASE_URL = "https://monitor-api.linode.com/v2/monitor/services" |
Contributor
There was a problem hiding this comment.
The base url should be just
https://monitor-api.linode.com
so you can allow to specify the api version. And in each command, i.e. get-metrics, you can build the specific url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
A CLI plugin for the ACLP metric-read-api
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
linode-cli get_metrics dbaas --entity-ids 123 --duration 15 --duration-unit min --metrics cpu_usage:avg --filters 'node_type:in:primary,secondary'
the help command prints the list of sample commands. A JWE token is required to be set to make these calls.
details on generating JWE token https://techdocs.akamai.com/linode-api/reference/post-get-token
API details: https://techdocs.akamai.com/linode-api/reference/post-read-metric
How do I run the relevant unit/integration tests?
python -m pytest tests/unit/test_plugin_get_metrics.py -v
for integration set, set a JWE_TOKEN env var for service type objectstorage
python -m pytest tests/integration/monitor/test_plugin_get_metrics.py -v