Merged
Conversation
mawilk90
requested review from
lgarber-akamai,
psnoch-akamai and
zliang-akamai
mawilk90
requested review from
dawiddzhafarov and
mgwoj
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing integration test by correcting the parameter order in the cluster_create method call and addressing a validation logic issue in the LKE cluster creation code.
Changes:
- Updated
cluster_createcall to use correct parameter order (version before node_pools) - Modified validation logic for empty node_pools check
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/integration/linode_client/test_linode_client.py | Corrected parameter order in cluster_create call to match API signature |
| linode_api4/groups/lke.py | Modified node_pools validation to wrap it in a list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
linode_api4/groups/lke.py
Outdated
| node_pools = [] | ||
|
|
||
| if len(node_pools) == 0 and ( | ||
| if len([node_pools]) == 0 and ( |
There was a problem hiding this comment.
Wrapping node_pools in a list will always result in a list of length 1 (containing the node_pools value), making len([node_pools]) == 0 always evaluate to False. This breaks the validation logic. The correct check should be len(node_pools) == 0.
mawilk90
force-pushed
the
hotfix/fix_failing_int_tests
branch
from
46ca82f to
e0e7748
Compare
zliang-akamai
approved these changes
Feb 4, 2026
psnoch-akamai
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix of failing integration test: test_cluster_create_with_api_objects
GHA:
https://github.com/linode/linode_api4-python/actions/runs/21513340644/job/61985555194
TOD:
http://198.19.5.79:1212/builds/697c9d485a27e3000184502a?team=DX&buildName=linode_api4&bld_id=697c9d485a27e3000184502a