qdl: Add support for up to 32 include folder when searching for files#197
Open
WilliamBright-IMD wants to merge 2 commits intolinux-msm:masterfrom
Open
qdl: Add support for up to 32 include folder when searching for files#197WilliamBright-IMD wants to merge 2 commits intolinux-msm:masterfrom
WilliamBright-IMD wants to merge 2 commits intolinux-msm:masterfrom
Conversation
WilliamBright-IMD
force-pushed
the
feature/Multiple_Include_Folders
branch
from
d136299 to
b6cff7f
Compare
…r files. This is particularly useful for yocto builds since binaries are generated into three folders whereas currently QDL only supports searching for files in two folders. Signed-off-by: William Bright <William.Bright@imd-tec.com>
WilliamBright-IMD
force-pushed
the
feature/Multiple_Include_Folders
branch
from
b6cff7f to
bd47e4a
Compare
Author
|
Hi @lumag , I don't have permissions to add a reviewer so I wonder if this PR has gone unnoticed. |
Collaborator
|
Problem description sounds reasonable to me. Would it make sense to use list.h to carry the list of include dirs instead of making it an array? Approving the workflow to get the build checks to run for now. |
Use list_head from list.h to carry include directories instead of a hardcoded 32-entry array, removing the arbitrary limit on the number of -i options. Formatting issues of the previous patch were also fixed in the process of making this change. Signed-off-by: William Bright <William.Bright@imd-tec.com>
Author
Thanks, I have pushed another commit with formatting corrections and the list.h change. I wasn't' sure if you want to fold this commit with the previous commit or not, so I will leave it up to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is particularly useful for yocto builds since binaries are generated into three folders whereas currently QDL only supports searching for files in two folders (if you pass a single -i argument)
You can use this new feature like below:
qdl -i folder1 -i folder2