meson: fix manpage_targets undefined when help2man is missing#216
Open
mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
Open
meson: fix manpage_targets undefined when help2man is missing#216mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
Conversation
alias_target('manpages', manpage_targets) was called unconditionally
but manpage_targets was only defined inside the help2man.found() block.
When help2man is not installed (e.g. during cross-compilation) meson
would abort with an "Unknown variable" error.
Fix by initialising manpage_targets to an empty list before the block
and guarding alias_target with a length check.
Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alias_target('manpages', manpage_targets) was called unconditionally but manpage_targets was only defined inside the help2man.found() block. When help2man is not installed (e.g. during cross-compilation) meson would abort with an "Unknown variable" error.
Fix by initialising manpage_targets to an empty list before the block and guarding alias_target with a length check.