qdl: fix list/ramdump subcommands ignored when flags precede them#217
Open
mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
Open
qdl: fix list/ramdump subcommands ignored when flags precede them#217mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
mukeshojha-linux wants to merge 1 commit intolinux-msm:masterfrom
Conversation
The list and ramdump subcommand checks in main() were done before any option parsing, so flags like --debug placed before the subcommand (e.g. qdl --debug list) would cause main() to miss the subcommand and fall through to qdl_flash(), resulting in an error. Fix by scanning argv for the subcommand while skipping over any leading option flags. Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list and ramdump subcommand checks in main() were done before any option parsing, so flags like --debug placed before the subcommand (e.g. qdl --debug list) would cause main() to miss the subcommand and fall through to qdl_flash(), resulting in an error.
Fix by scanning argv for the subcommand while skipping over any leading option flags.