Makefile: make sure coreboot forks do the right thing when there is no .canary file but coreboot fork directory exists#1968
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom May 5, 2025
Conversation
…o .canary file but coreboot fork directory exists Improves collaboration with Makefile real.remove_canary_files-extract_patch_rebuild_what_changed helper: - if canary is not found but coreboot fork directory exists: do not attempt to git clone; git reset instead and reuse previous logic - if canary is not found and coreboot dir doesn't exist: git clone Signed-off-by: Thierry Laurion <insurgo@riseup.net>
e49407f to
c324a83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves collaboration with Makefile real.remove_canary_files-extract_patch_rebuild_what_changed helper:
Fix issues when building multiple boards not using the same coreboot fork and using the
./docker_repro.sh make BOARD=xyz real.remove_canary_files-extract_patch_rebuild_what_changedNote:
real.remove_canary_files-extract_patch_rebuild_what_changed wipes all .canary files, where previous coreboot .canary logic was cloning git repo if .canary was missing, resulting in an error.
Improves on #1953 prior work