Open
Conversation
Author
|
Oh, just to add, do you think it might be worth adding a single bit mode to this? Another possible failure mode is "shorted" bits. By testing a byte at a time those can be missed. The solution is to test one bit at a time, but of course it takes 8x as long. Another option is to test with #55 and #AA, which would only double the test time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the MARCH C- test to the lower RAM test. If I have time to understand how it works, I could add it to the upper RAM test. I'm not an Amstrad CPC guy though, I don't know a lot about it or how the memory expansion works.
MARCH C- has the advantage of detecting addressing faults, as well as SRAM bit and data bus faults. Since it runs pretty quickly I just kept the current test in there too.