chore: modernize CI and document deprecated ioutil usages #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modernizes CI infrastructure and prepares the codebase for future Go version upgrades by documenting all deprecated ioutil usages. ## CI Modernization - Update actions/checkout from v3 to v6 - Update actions/setup-go from v4 to v6 - Add explicit permissions block for security best practices - Extend Go version matrix to include 1.22.x through 1.25.x - Remove Go 1.11.x from CI matrix (go.mod specifies go 1.12) - Maintain backward compatibility with Go 1.12.x through 1.21.x ## Build Constraint Cleanup Merge parse/testdata/subcommand_1.9.go into subcommands.go. The go1.9 build constraint is obsolete since the minimum supported version (1.12) already supports type aliases. This simplifies the test fixtures. ## Deprecated ioutil Documentation Add TODO comments to all ioutil package usages documenting: - Which function is deprecated - The modern replacement (available since Go 1.16) - Reference to the Go 1.16 release notes The ioutil package was deprecated in Go 1.16, but the code continues to work correctly. These comments prepare for a future migration when the minimum Go version is raised to 1.16+. Affected functions and their replacements: - ioutil.Discard -> io.Discard - ioutil.TempDir -> os.MkdirTemp - ioutil.TempFile -> os.CreateTemp - ioutil.ReadFile -> os.ReadFile - ioutil.WriteFile -> os.WriteFile - ioutil.ReadDir -> os.ReadDir ## Test Fix Fix TestBootstrap to use `go env GOBIN` instead of hardcoded $GOPATH/bin, which may not be set in module-aware mode (Go 1.16+ defaults to module mode). ## Compatibility - Minimum Go version: 1.12 (unchanged, now enforced in CI) - No API changes - All existing tests continue to pass
Author
|
resolves #534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modernizes CI infrastructure and prepares the codebase for future Go version upgrades by documenting all deprecated ioutil usages.
CI Modernization
Build Constraint Cleanup
Merge parse/testdata/subcommand_1.9.go into subcommands.go. The go1.9 build constraint is obsolete since the minimum supported version (1.12) already supports type aliases. This simplifies the test fixtures.
Deprecated ioutil Documentation
Add TODO comments to all ioutil package usages documenting:
The ioutil package was deprecated in Go 1.16, but the code continues to work correctly. These comments prepare for a future migration when the minimum Go version is raised to 1.16+.
Affected functions and their replacements:
Test Fix
Fix TestBootstrap to use
go env GOBINinstead of hardcoded $GOPATH/bin, which may not be set in module-aware mode (Go 1.16+ defaults to module mode).Compatibility