Add Homebrew-based update support for limited apps#564
Add Homebrew-based update support for limited apps#564Qetesh wants to merge 1 commit intomangerlahn:mainfrom
Conversation
|
I don't think this is ready to merge yet. The main problem is that this changes Homebrew from an external/open-only path into a built-in There is also a regression in the current "limited support" behavior. Homebrew apps still report Before merging, I'd want either a reliable ownership check that confirms the app/cask is already installed and managed by Homebrew before offering the built-in update path, or to keep Homebrew in the external flow until that check exists. |
|
Thank you for the detailed feedback. I agree that forcing Homebrew to take over apps that were not originally managed by Homebrew is a real problem, and it should not happen implicitly. A better direction may be to make this an explicit user choice instead of a built-in update path for all limited apps. For example:
In both cases, Latest could show a clear warning that this may change how the app is managed, may replace a manually installed version with a Homebrew-managed one, and may cause compatibility issues in some cases. In my own usage, this approach has generally worked well and makes updating very convenient, but I agree that there are still some incompatibility cases and edge cases. If an app is taken over this way, it may also make sense to introduce a separate Homebrew-specific state instead of keeping it under If that seems more aligned with the project, I’d be happy to rework the PR in that direction. Thanks again for the thoughtful review. |
|
Explicit opt-in is a much better direction. My main concern is still that Latest should not silently infer "this app is managed by Homebrew now" from a loose name / bundle-ID match plus the presence of Homebrew on the system. If this is reworked, I think the safe bar should be:
I also think the support/filtering model needs to stay coherent. Right now Implementation-wise, I’d probably split it into two phases:
I’d also keep the state model explicit instead of deriving everything from
That should make the UI, filtering, and update counting much easier to keep consistent. So yes, I think a rework in that direction makes sense. I’d just want the revised PR to keep the distinction clear between:
Also, just for context: I’m not the maintainer here and I’ve only been looking at this project for the past two days, so this is only one more opinion in the discussion. Ultimately the maintainer will need to decide what direction makes the most sense for Latest. |
Hi, first of all, thank you for creating this project. I really like this tool and appreciate the work you’ve put into it.
I personally have a strong habit of keeping my apps up to date, so this project is especially useful to me. While using it, I noticed that many apps are currently in a limited state and can only be updated manually. Because of that, I tried adding support for updating those apps through Homebrew, using brew reinstall --cask --force.
Along with that, I also adjusted the description and colors for the limited support state, with the colors inspired by Homebrew’s visual style.
This is a relatively significant change, so I’d like to use this PR as a starting point for discussion: whether this direction makes sense for the project, and whether the implementation approach is appropriate.
Thanks again for the great app — I’d be very happy to hear your thoughts.