Conversation
|
Tests fail because @kjkim-kr, did you manage to run opensfm successfully after this fix? If so we could consider adding the dependency. |
|
Hi @kjkim-kr! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@felipe-carvalho Since I am currently a bit stuck on Windows, I am also trying to build OpenSfM on Windows. I am basically able to build OpenSfM with MinGW. The only issue I have run into so far is an ABI issue where As soon as I get it running I am going create a PR so that we should have a build path for Windows. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I have checked at Ubuntu 16.04, two values(13598720) are equal
`Python 3.5.2 (default, Oct 8 2019, 13:06:37)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
`
and psutil also runs successfully at Windows
`Microsoft Windows [Version 10.0.17134.950]
(c) 2018 Microsoft Corporation. All rights reserved.
C:\Users\KJ>python
Python 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 03:37:03) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
`