Skip to content

Add support for AsyncHTTPClient #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 11 commits into from
Feb 17, 2026
Merged

Add support for AsyncHTTPClient #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
55bbe27
Add support for AsyncHTTPClient
mattt Feb 17, 2026
8e338ed
Consolidate HTTPClient implementation into single file
mattt Feb 17, 2026
6910db5
Update CI workflow
mattt Feb 17, 2026
0e1def5
Update README with information about Async HTTP Client
mattt Feb 17, 2026
f600720
Update CI workflow to build without traits
mattt Feb 17, 2026
8d48e36
Incorporate feedback from review
mattt Feb 17, 2026
07b2c4f
Fix build failures on Linux
mattt Feb 17, 2026
ffac4af
Update CI workflow to include trait in matrix
mattt Feb 17, 2026
d71a8bd
Fix plugin smoke test step
mattt Feb 17, 2026
140bfa5
Improve aesthetics of job names
mattt Feb 17, 2026
4f19272
Add missing FoundationNetwork import
mattt Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
test-macos:
name: Swift ${{ matrix.swift }} on macOS ${{ matrix.macos }} with Xcode ${{ matrix.xcode }}
name: Swift ${{ matrix.swift }} on macOS ${{ matrix.macos }} with Xcode ${{ matrix.xcode }}${{ matrix.variant == 'async_http_client' && ' (AsyncHTTPClient)' || '' }}
runs-on: macos-${{ matrix.macos }}
env:
DEVELOPER_DIR: "/Applications/Xcode_${{ matrix.xcode }}.app/Contents/Developer"
Expand All @@ -19,9 +19,19 @@ jobs:
- swift: "6.1"
xcode: "16.3"
macos: "15"
variant: default
- swift: "6.2"
xcode: "26.0"
macos: "26"
variant: default
- swift: "6.1"
xcode: "16.3"
macos: "15"
variant: async_http_client
- swift: "6.2"
xcode: "26.0"
macos: "26"
variant: async_http_client
timeout-minutes: 10
steps:
- name: Checkout code
Expand All @@ -33,31 +43,46 @@ jobs:
path: |
~/.cache/org.swift.swiftpm
.build
key: ${{ runner.os }}-swift-${{ matrix.swift }}-spm-${{ hashFiles('**/Package.resolved') }}
key: ${{ runner.os }}-swift-${{ matrix.swift }}-${{ matrix.variant }}-spm-${{ hashFiles('**/Package.resolved') }}
restore-keys: |
${{ runner.os }}-swift-${{ matrix.swift }}-spm-
${{ runner.os }}-swift-${{ matrix.swift }}-${{ matrix.variant }}-spm-

- name: Configure variant
run: |
if [ "${{ matrix.variant }}" = "async_http_client" ]; then
echo "SWIFT_VARIANT_ARGS=--traits AsyncHTTPClient --scratch-path .build/async-http-client" >> "$GITHUB_ENV"
else
echo "SWIFT_VARIANT_ARGS=--scratch-path .build/default" >> "$GITHUB_ENV"
fi

- name: Lint
run: swift format lint --strict --recursive .

- name: Build
run: swift build -v
run: swift build $SWIFT_VARIANT_ARGS

- name: Smoke test plugin
run: swift package plugin --allow-writing-to-package-directory replay --help
if: matrix.variant == 'default'
run: swift package --scratch-path .build/default plugin --allow-writing-to-package-directory replay --help

- name: Test
run: swift test -v
run: swift test $SWIFT_VARIANT_ARGS

test-linux:
name: Swift ${{ matrix.swift-version }} on Linux
name: Swift ${{ matrix.swift-version }} on Linux${{ matrix.variant == 'async_http_client' && ' (AsyncHTTPClient)' || '' }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
swift-version:
- "6.1.3"
- "6.2.3"
include:
- swift-version: "6.1.3"
variant: default
- swift-version: "6.2.3"
variant: default
- swift-version: "6.1.3"
variant: async_http_client
- swift-version: "6.2.3"
variant: async_http_client
timeout-minutes: 10
steps:
- name: Checkout code
Expand All @@ -68,14 +93,23 @@ jobs:
with:
toolchain: ${{ matrix.swift-version }}

- name: Configure variant
run: |
if [ "${{ matrix.variant }}" = "async_http_client" ]; then
echo "SWIFT_VARIANT_ARGS=--traits AsyncHTTPClient --scratch-path .build/async-http-client" >> "$GITHUB_ENV"
else
echo "SWIFT_VARIANT_ARGS=--scratch-path .build/default" >> "$GITHUB_ENV"
fi

- name: Lint
run: swift format lint --strict --recursive .

- name: Build
run: swift build -v
run: swift build $SWIFT_VARIANT_ARGS

- name: Smoke test plugin
run: swift package plugin --allow-writing-to-package-directory replay --help
if: matrix.variant == 'default'
run: swift package --scratch-path .build/default plugin --allow-writing-to-package-directory replay --help

- name: Test
run: swift test -v
run: swift test $SWIFT_VARIANT_ARGS
200 changes: 199 additions & 1 deletion Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 13 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,23 @@ let package = Package(
targets: ["ReplayPlugin"]
),
],
traits: [
.trait(name: "AsyncHTTPClient")
],
dependencies: [
.package(url: "https://github.com/apple/swift-argument-parser.git", from: "1.5.0")
.package(url: "https://github.com/apple/swift-argument-parser.git", from: "1.5.0"),
.package(url: "https://github.com/swift-server/async-http-client.git", from: "1.24.0"),
],
targets: [
.target(
name: "Replay"
name: "Replay",
dependencies: [
.product(
name: "AsyncHTTPClient",
package: "async-http-client",
condition: .when(traits: ["AsyncHTTPClient"])
)
]
),
.executableTarget(
name: "ReplayCLI",
Expand Down
Loading