Skip to content

Modify BFL residual#86

Merged
A-CGray merged 5 commits intomainfrom
BFL
Mar 25, 2026
Merged

Modify BFL residual#86
A-CGray merged 5 commits intomainfrom
BFL

Conversation

@A-CGray
Copy link
Copy Markdown
Member

@A-CGray A-CGray commented Feb 16, 2026

Purpose

In the balanced field length group, the decision speed $V_1$ is supposed to be solved for such that the abort and continue distance are equal. A fallback is required if these distances cannot be made equal while satisfying $V_1 \leq V_r$. To handle this, the docstring of the BFLImplicitSolve says the following:

This residual is equal to zero if:
	- The rejected takeoff and engine-out takeoff distances are equal, or:
	- V1 is equal to VR and the engine out takeoff distance is longer than the RTO distance

This PR simply cleans up the implementation of this logic in the code to make it more comprehensible

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner February 16, 2026 16:54
@A-CGray A-CGray requested a review from sabakhshi February 16, 2026 16:54
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.05%. Comparing base (9187a53) to head (7b8e0b5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         103      103           
  Lines       10729    10730    +1     
=======================================
+ Hits         8804     8805    +1     
  Misses       1925     1925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A-CGray A-CGray merged commit 0d2adeb into main Mar 25, 2026
11 checks passed
@A-CGray A-CGray deleted the BFL branch March 25, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants