Skip to content

Support calling addObjective on subset of procs#465

Merged
kanekosh merged 2 commits intomainfrom
finalizeObjectives
Oct 23, 2025
Merged

Support calling addObjective on subset of procs#465
kanekosh merged 2 commits intomainfrom
finalizeObjectives

Conversation

@A-CGray
Copy link
Copy Markdown
Member

@A-CGray A-CGray commented Oct 17, 2025

Purpose

Adds a _finalizeObjectives method that reduces any added objectives across all procs so that all procs have the same objectives. This is already done for design variables and constraints.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I added a small unit test that checks that all procs have the same objectives, constraints and design variables after finalize is called.

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants