Disable GetMultimemAddress test for ncclx v2_29#2263
Open
pavanbalaji wants to merge 2 commits intometa-pytorch:mainfrom
Open
Disable GetMultimemAddress test for ncclx v2_29#2263pavanbalaji wants to merge 2 commits intometa-pytorch:mainfrom
pavanbalaji wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
Summary: Move the stable symlink from v2_28 to v2_29 in both the ncclx directory symlink and the nccl_deps.bzl tag mapping. Differential Revision: D101847353
Summary: The GetMultimemAddress test fails on 1x2 (2-rank) configurations because the device-side ncclDevCommCreate does not request NVLS multimem when nRanks <= 2 (NCCLDeviceBackend.cpp gating), while the host-side winGetLsaMultimemDevicePointer returns a valid address unconditionally. This test was newly activated by the v2_28 -> v2_29 stable symlink bump. Disable the test until the multimem gating inconsistency between host and device APIs is resolved. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: networkai_host Reviewed By: rmahidhar Differential Revision: D102305713
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@pavanbalaji has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102305713. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The GetMultimemAddress test fails on 1x2 (2-rank) configurations
because the device-side ncclDevCommCreate does not request NVLS
multimem when nRanks <= 2 (NCCLDeviceBackend.cpp gating), while the
host-side winGetLsaMultimemDevicePointer returns a valid address
unconditionally. This test was newly activated by the v2_28 -> v2_29
stable symlink bump.
Disable the test until the multimem gating inconsistency between host
and device APIs is resolved.
overriding_review_checks_triggers_an_audit_and_retroactive_review
Oncall Short Name: networkai_host
Reviewed By: rmahidhar
Differential Revision: D102305713