Fix example command in sandbox/rl_trainer/main.py#622
Fix example command in sandbox/rl_trainer/main.py#622daniellepintz wants to merge 1 commit intomainfrom
sandbox/rl_trainer/main.py#622Conversation
The current example config does not work because it runs on slurm. Fixing to a command that does work and runs locally.
|
hey, happy to approve, but can you help me understand why 1.7b would run but 30b wouldnt? |
|
hey I saw this issue today. imo this isn't the right fix. the problem is that the |
JenniferWang
left a comment
There was a problem hiding this comment.
See the comments above
|
yes indeed the problem is |
|
@felipemello1 @daniellepintz this is, generally speaking a UX problem -- what's our default examples to be based on? Local DevGPU with 8 card? On the other hand, for now, we can certainly augment the example run command with different mode override. Given that the comment is accurate. I suggest closing the PR and include the improvement in the UX work. |
The current example config does not work because it runs on slurm. Fixing to a command that does work and runs locally.